-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue compiling bcrypt with latest port compiler (v1.9.1) #48
Comments
Similar problem with
|
Similar problems with stun module
|
Same issue with erlexec and gcc 4.8.x:
|
Quick fix is to pin down the plugin version you're importing. Hex.pm shows pc 1.9.1 was released yesterday; 1.8.0 still works well for me. {plugins,
[{pc, "1.8.0"} % rather than just 'pc'
]}. |
The problem seems to arise only for compiling dependencies. For example, if I try to compile |
pc 1.9.1 seems to crash when used to compile a dependency. See blt/port_compiler#48
@Tuncer ^. please next time you ask me to publish first test it on jiffy and bcrypt. |
Should I publish a 1.9.2 that is just 1.8.0? or are people ok pinning for now? |
@tsloughter I suggest you to publish 1.9.2. Most projects are using unpinned pc since it is the recommended way according to rebar3 example: https://www.rebar3.org/docs/using-available-plugins#section-port-compiler There is no way to ask all dependency maintainers to pin pc. |
Ok, I've published 1.10.0 which is really 1.6.0. Please let me now that it is working, you'll need to do a |
Ok, tested. It works now. Cheers! |
Yep, this fixes the issue. I think we'll keep the port compiler pegged for the future (or until rebar3 can automatically lock plugins if that makes sense) to make our builds as reproducible as possible. Thanks for the fast fix! Very much appreciated! |
Sorry about the regression, will look into it. @tsloughter, can you hook up a CI service in the project settings so that tests can be added? |
The regression was introduced in #37 (/cc @cjkjellander). Given the existing config files out there, let's revert it. See #49. |
#50 is a compromise that merely warns but doesn't pass the pattern as is to CXX/CC. |
Wider testing welcome. |
Any negative test results? Otherwise, I will tag a new release. |
Just tested using master (9412b2c) for compiling VerneMQ and that works. 👍 |
Thanks, tagged |
Hi,
With the v1.9.1 version published on hex we have an issue building bcrypt (a VerneMQ dependency). We get:
The above is reproducible with a clean erlang project with the following
rebar.config
file:The last version i I could find is this:
I used rebar v3.5.3.
The text was updated successfully, but these errors were encountered: