Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gas_refunded in EVM #167

Closed
ngotchac opened this issue Aug 10, 2022 · 4 comments
Closed

Expose gas_refunded in EVM #167

ngotchac opened this issue Aug 10, 2022 · 4 comments

Comments

@ngotchac
Copy link
Contributor

Hi,

For a private project, I would need to get access to the gas_refunded value computed during the finalization phase of a transaction's execution. This is useful, in conjunction with the gas_used to better estimate the required gas of a transaction.

I already have it implemented here, but it introduces some changes to this crate's API, which is why I didn't open a PR. I'm not sure what's the best path here...

@rakita
Copy link
Member

rakita commented Aug 10, 2022

If project is private, I would need you and your extended family to sign the pack of publicness ( just kidding).

API should be changed to return this value, would probably introduce a new struct as this would be the 6th output field.

@ngotchac
Copy link
Contributor Author

Aha yeah sorry I don't really have a choice about its publicness :/
Yeah I was also thinking about returning a struct since the tuple is getting quite big. Should I make a PR then?

@rakita
Copy link
Member

rakita commented Aug 10, 2022

go for it

@rakita
Copy link
Member

rakita commented Aug 12, 2022

@ngotchac thank you for contributing!

@rakita rakita closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants