Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests, Python 3 #44

Merged
merged 34 commits into from
Apr 16, 2019
Merged

Unittests, Python 3 #44

merged 34 commits into from
Apr 16, 2019

Conversation

rnixx
Copy link
Member

@rnixx rnixx commented Apr 15, 2019

This PR supersedes #43.

All Doctests are converted to unittests.

Use bytes_mode=False with python-ldap. This way, DNs, RDNs and attribute names are handled as text by python-ldap. This is the default behavior of python-ldap in python 3.

rnixx added 30 commits April 13, 2019 13:50
@coveralls
Copy link

Coverage Status

Coverage increased (+5.0%) to 99.485% when pulling 4f022e0 on unittests into b0cf548 on master.

@rnixx rnixx merged commit fcf2716 into master Apr 16, 2019
@jensens jensens deleted the unittests branch April 9, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants