Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo video not working in the Carousel video gallery #272

Open
danielsian opened this issue Oct 2, 2022 · 2 comments
Open

Vimeo video not working in the Carousel video gallery #272

danielsian opened this issue Oct 2, 2022 · 2 comments

Comments

@danielsian
Copy link

https://blueimp.github.io/Gallery/

KN1GHT - Last Moon video won't start doesn't matter the browser.

Is this a bug?

@sebastian-marinescu
Copy link

Hi @danielsian,

I can see @blueimp is still using the old library:
https://github.com/blueimp/Gallery/blob/master/js/blueimp-gallery-vimeo.js#L65

And this seems to be deprecated:
https://github.com/vimeo/player.js#migrate-from-froogaloop
https://github.com/vimeo/player.js/blob/master/docs/migrate-from-froogaloop.md

I can see a PR for this #271 and another fork also handling it
master...mediataivas:Gallery:master

So you either take one of the two forks, or you wait until the PR is tested and merged.

@sebastian-marinescu
Copy link

Also, this seems to be a duplicate of #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants