Improve deviceid_decoder #1414
Merged
Improve deviceid_decoder #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
idk exactly how I messed that up. but in my original it makes sense: IIRC, UAVCAN and EAHRS do not provide the ID, so I did that in order to not show the wrong device |
Based on the original reference: https://docs.px4.io/main/en/middleware/drivers.html That [this code](https://github.com/ArduPilot/ardupilot/blob/master/Tools/scripts/decode_devid.py) was based. It shows that the `UAVCAN` and `eAHRS` does not exist on the devtype map for Compass: https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Compass/AP_Compass_Backend.h#L55 Fix the check and update the comments explaining what is going on Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
devid_returns
branch
from
17be0a0
to
25a9108
Compare
|
@Williangalvani check now |
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
devid_returns
branch
from
b42ceca
to
e64ac9d
Compare
Williangalvani
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.