Wizard: Configure boat firmware and support custom page configuration #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…uration Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
break-wizard
branch
from
60a9a65
to
ec24c32
Compare
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
patrickelectric
force-pushed
the
break-wizard
branch
from
ec24c32
to
fa56d03
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…mwares andd installFirmwareFromUrl functions Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…work changes Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…installation Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
break-wizard
branch
from
fa56d03
to
875aa03
Compare
Williangalvani
approved these changes
May 24, 2023
| url: `${autopilot.API_URL}/install_firmware_from_url`, | ||
| timeout: 30000, | ||
| params: { | ||
| // eslint-disable-next-line object-shorthand |
There was a problem hiding this comment.
has anything bad happened if you tried used object shorthand?
There was a problem hiding this comment.
has anything bad happened if you tried used object shorthand?
Yes, the json does not have a key, just a value.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows wizard to request user to connect to internet and install firmware for current board