Make parameters and scripts loader update based on is_online from Wizard #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fetch firmware version on online watcher to avoid cases where vehicle_type does not change and onMounted hook ran when vehicle was offline
* Does not select by deafult "not_load_default_params_option" if there are available options in filtered_params_set_names
* Add better state management and make sure that when vehicle type updates new scripts and parameters are fetch everytime avoid broken configs
JoaoMario109
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
patrickelectric
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2580