Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken: Move API to dedicated module #2604

Merged
merged 2 commits into from
May 20, 2024
Merged

Kraken: Move API to dedicated module #2604

merged 2 commits into from
May 20, 2024

Conversation

JoaoMario109
Copy link
Collaborator

Depends on #2601

  • Move kraken API from main to dedicated module
  • Add API V2 skeleton

@JoaoMario109 JoaoMario109 force-pushed the add-v2-api-endpoints branch 9 times, most recently from 03ee544 to 967b9c5 Compare May 20, 2024 10:28
@JoaoMario109 JoaoMario109 marked this pull request as ready for review May 20, 2024 12:14
patrickelectric
patrickelectric requested changes May 20, 2024
View reviewed changes
core/services/kraken/api/app.py Outdated Show resolved Hide resolved
core/services/kraken/api/app.py Outdated Show resolved Hide resolved
core/services/kraken/api/app.py Outdated Show resolved Hide resolved
core/services/kraken/api/v1/routers/extension.py Outdated Show resolved Hide resolved
core/services/kraken/kraken.py Outdated Show resolved Hide resolved
core/services/kraken/config.py Show resolved Hide resolved
@JoaoMario109 JoaoMario109 force-pushed the add-v2-api-endpoints branch 6 times, most recently from d48384f to 0a5ae9e Compare May 20, 2024 14:14
@JoaoMario109
kraken: api: Move API to dedicated module
73c770b 
* Move Kraken API to dedicated module and add skeleton of API V2 as
  preparation for kraken V2 refactor
@JoaoMario109 JoaoMario109 mentioned this pull request May 20, 2024
Merged
@patrickelectric patrickelectric merged commit 9a0a1b6 into bluerobotics:master May 20, 2024
6 checks passed
@JoaoMario109 JoaoMario109 mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoaoMario109 @patrickelectric