Kraken: Add Manifest V2 with multiple manifest support #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
force-pushed
the
add-manifest-v2-module
branch
24 times, most recently
from
d7458a2
to
642eadd
Compare
JoaoMario109
force-pushed
the
add-manifest-v2-module
branch
2 times, most recently
from
1e90798
to
4aee47f
Compare
Williangalvani
requested changes
May 24, 2024
There was a problem hiding this comment.
This is looking very good!
I have 3 comments though:
- Can we show on the list if a manifest is disabled? currently we need to click the edit button.
- Can we decrease the timeouts? 20s is a LONG time for waiting before giving the user some feedback, specially on post/delete.
- we should add some url validation in the form, just in case. (I added gibberish and it gave me an internal error)
JoaoMario109
force-pushed
the
add-manifest-v2-module
branch
3 times, most recently
from
5b14f4e
to
4b16d3a
Compare
patrickelectric
approved these changes
May 28, 2024
* Add new manifest module with multiple manifest sources support
JoaoMario109
force-pushed
the
add-manifest-v2-module
branch
from
4b16d3a
to
1f4f162
Compare
patrickelectric
approved these changes
May 29, 2024
|
It'll be merged once the change request from @Williangalvani get solved. (Needs approval) |
Williangalvani
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2604