-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pymavlink set_mode ack, wrong constant being used #245
Comments
Yes, I believe that's correct. |
I see, thanks for the explanation! In your example you used two constants
I just pushed a PR, should I update it to also put the two constants there? |
I included both at the time for compatibility, and because I wasn’t sure whether the message was used by any of the send options. Looking again the acknowledgement is using the command protocol, which presumably wasn’t used when it was just a ‘message’, so receiving the message ID there is likely impossible anyway. |
On https://www.ardusub.com/developers/pymavlink.html
There's a part that explains how to wait for the ack:
But this constant:
MAVLINK_MSG_ID_SET_MODE
seemingly should beMAV_CMD_DO_SET_MODE
? Because when I ran the snippet above, it just stuck in that if statement (if ack_msg['command'] != mavutil.mavlink.MAVLINK_MSG_ID_SET_MODE:
)I was using Ardupilot SITL btw, not the Ardusub one, but shouldn't they use the same constant?
The text was updated successfully, but these errors were encountered: