Implement new UI to Configurations - general #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Edit: there's a small CI problem about an unused import to be solved. |
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
from
653ee9a
to
5b04bda
Compare
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
from
00c454a
to
d041017
Compare
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
rafaellehmkuhl
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
This new UI is simply beautiful!
There's a small bug preventing the closing of the sub-menus as well as the main-menu (the only way to do it right now seems to be by re-clicking the sub-menu button and them clicking the main-menu button), but I will open an issue for us to tackle that afterwards.
rafaellehmkuhl
merged commit aabdaed
into
bluerobotics:interface-rework
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main features:
Main menu and configs submenu responsiveness with simplified versions for small screen devices;
New Modal and Expansible-panels Vue components;
Refactoring of General Configurations component to suits the new UI and fit on different screen sizes;
Main responsiveness logic (store and Tailwind) updated;
Information/help drawers added:
https://github.com/bluerobotics/cockpit/assets/14910201/42f0ea58-63fc-4c35-a8dc-b356134924bb
Regular size screens:
https://github.com/bluerobotics/cockpit/assets/14910201/c8c67845-fcf5-43a7-8d1f-d2e2477f4e4a
Very small screens:
https://github.com/bluerobotics/cockpit/assets/14910201/63df7c5b-4140-4fb6-99f5-6a55bec1110e
Closes #969