Use edit-mode to remove mini-widgets from the MiniWidgetBar
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces direct usage of the `editingMode` variable, so widgets can benefit from directly controlling and overhiding the default behavior.
With this new approach, we are able to remove mini-widgets from the `MiniWidgetBar` in an intuitive and transparent way. The user can basically drag mini-widgets out of the container while in edit-mode, instead of having to get out of edit-mode and click on the widget edit button.
patrickelectric
approved these changes
Sep 19, 2023
|
Relevant to #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the possibility of controlling movement allowance on a per-widget basis. This was needed in cases where the widget has drag-and-drop features, like the
MiniWidgetBar, as if one were to use this drag-and-drop features while on edit-mode, the widget would be moved, instead of the wanted behavior.With that change, we modified the
MiniWidgetBarso it doesn't have its own edit-mode anymore, and instead uses the regular general edit-mode from Cockpit to edit its interface.