Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update joystick pipeline architecture and add modifier/shift buttons support #553

Merged
merged 22 commits into from Dec 8, 2023
Merged

Update joystick pipeline architecture and add modifier/shift buttons support #553

merged 22 commits into from Dec 8, 2023

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Nov 7, 2023 •
edited

Fix #507
Fix #453

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@rafaellehmkuhl rafaellehmkuhl force-pushed the add-mavlink-shift-mapping branch 2 times, most recently from b7bd580 to d49672d Compare November 9, 2023 22:51
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 22, 2023
@ES-Alexander
Copy link
Contributor

I've put various interface suggestions in #617 :-)

@rafaellehmkuhl
Use intern Vue capitalize method when possible
2aebc84 
Much more readable.
@rafaellehmkuhl
Rename protocol name from MAVLink to MAVLinkManualControl
15fec30 
Being more specific makes it clear that we are talking about `MANUAL_CONTROL` messages on MAVLink, so we don't confuse this with a MAVLink `COMMAND` message, for example, which is used on boats and other vehicles.
@rafaellehmkuhl rafaellehmkuhl force-pushed the add-mavlink-shift-mapping branch 4 times, most recently from 18f052a to 1537800 Compare December 7, 2023 00:09
@rafaellehmkuhl rafaellehmkuhl force-pushed the add-mavlink-shift-mapping branch 2 times, most recently from 9334f43 to 194ad9b Compare December 7, 2023 00:47
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review December 7, 2023 00:48
patrickelectric
patrickelectric approved these changes Dec 8, 2023
View reviewed changes
src/libs/joystick/protocols/mavlink-manual-control.ts
relay2_momentary = 'Relay 2 momentary', // 105
relay3_momentary = 'Relay 3 momentary', // 106
relay4_momentary = 'Relay 4 momentary', // 107
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the scripts calls https://github.com/ArduPilot/ardupilot/blob/d1ad9ccfbb1f6988539f8c188401aeebd1305760/libraries/AP_JSButton/AP_JSButton.h#L115

src/libs/joystick/protocols/mavlink-manual-control.ts
relay2_momentary = 'Relay 2 momentary', // 105
relay3_momentary = 'Relay 3 momentary', // 106
relay4_momentary = 'Relay 4 momentary', // 107
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also ArduPilot related, not MAVLink, since Px4 does not provide the same buttons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if there's somewhere we can consume that data from? Or should we have our own database?

@patrickelectric patrickelectric merged commit 40a203c into bluerobotics:master Dec 8, 2023
7 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-mavlink-shift-mapping branch December 8, 2023 17:07
@rafaellehmkuhl rafaellehmkuhl mentioned this pull request Dec 8, 2023
Merged
@ES-Alexander ES-Alexander mentioned this pull request Dec 12, 2023
Merged
12 tasks
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
c37695f 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
7cc7687 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
b27bb6f 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
35c22b9 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
cc90466 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
f78f3ac 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@ES-Alexander ES-Alexander Awaiting requested review from ES-Alexander

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
4 participants
@rafaellehmkuhl @CLAassistant @ES-Alexander @patrickelectric