Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hiding bottom bar momentarily through a Cockpit Action #554

Merged
merged 1 commit into from Nov 8, 2023
Merged

Allow hiding bottom bar momentarily through a Cockpit Action #554

merged 1 commit into from Nov 8, 2023

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl merged commit 137e89c into bluerobotics:master Nov 8, 2023
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the allow-hiding-bottom-bar-for-now branch November 8, 2023 14:37
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 9, 2023
@ES-Alexander
Copy link
Contributor

Docs key points:

  • add image of View configuration UI
  • mention that the bottom-bar hiding is a boot option, but is always overridable during operation with a cockpit action

@ES-Alexander ES-Alexander mentioned this pull request Dec 12, 2023
Merged
12 tasks
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
c37695f 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
7cc7687 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
b27bb6f 
Documents:
- bluerobotics#123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
35c22b9 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
cc90466 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander
advanced-usage: cover joystick protocols
f78f3ac 
Documents:
- #123
- bluerobotics/cockpit#554
- bluerobotics/cockpit#553
- bluerobotics/cockpit#452
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: we could auto hide the bottom bar, and show it back with a touch input
3 participants
@rafaellehmkuhl @ES-Alexander @patrickelectric