main-vehicle: allow setting vehicle and stream urls via query #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patrickelectric
approved these changes
Jan 4, 2024
rafaellehmkuhl
requested changes
Jan 8, 2024
There was a problem hiding this comment.
This is not working for me.
I've tried accessing a local vehicle (regular URL e.g.: 192.168.0.99) and it didn't connect.
It works fine on master.
Console shows:
WebSocket connection to 'ws://192.168.0.99/ws/mavlink' failed:
It only works if I explicitly set the m2r address as ws://192.168.0.99:6040/ws/mavlink.
Williangalvani
force-pushed
the
query_urls
branch
from
be99cdf
to
858e608
Compare
I'll fix the pr |
Williangalvani
force-pushed
the
query_urls
branch
from
858e608
to
4e9aeaf
Compare
Williangalvani
force-pushed
the
query_urls
branch
2 times, most recently
from
e83cdb7
to
6f6dfbb
Compare
Williangalvani
force-pushed
the
query_urls
branch
from
6f6dfbb
to
9fcc278
Compare
rafaellehmkuhl
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it results in some rather ugly urls, but it works 馃し