Further performance improvements #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a is in the current view)
…is not visible Cockpit is considered not visible if the tab was changed or if the browser window was minimized.
patrickelectric
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch leads to a huge improvement in Cockpit's performance, as it forces resource-intensive widgets that are not visible to not re-render.
I tried using the checkVisibility property, but it does not work on our case since the elements are in the DOM, just not on top.
On my computer, it reduced the CPU usage of the Cockpit tab in about 30%. It also prevented crashes that were happening when I left Cockpit open in the background.