Fix address reactivity in general configuration view #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
force-pushed
the
406-fix-address-reactivity
branch
2 times, most recently
from
8e82033
to
e869719
Compare
JoaoMario109
requested review from
rafaellehmkuhl,
patrickelectric and
ArturoManzoli
* Change MainVehicleConnetion and WebRTCConnection URIs to use storage and to be reactive * Change video.ts to use new computed property
JoaoMario109
force-pushed
the
406-fix-address-reactivity
branch
from
e869719
to
0c2102f
Compare
rafaellehmkuhl
requested changes
Jun 18, 2024
JoaoMario109
force-pushed
the
406-fix-address-reactivity
branch
from
0c2102f
to
f7de251
Compare
* Change the way as the URIs are configured to make sure they are reactive and stored properly on storage when using custom ones
JoaoMario109
force-pushed
the
406-fix-address-reactivity
branch
from
f7de251
to
41a9be8
Compare
rafaellehmkuhl
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Lago, there's just one more problem: when the user clicks to activate the custom address in the WebRTC, it reloads the page immediately, even if the custom address that is there is equal to the default one. I think we should check before to see if they are not the same, and not reload in that case.
rafaellehmkuhl
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406
Fix #924