Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve video deletion UI #955

Conversation

ArturoManzoli
Copy link
Contributor

  • Added extra conformation button on Video Delete;
  • Modified confirmation buttons positions and animation;

Fix #951

@rafaellehmkuhl
Copy link
Member

As this is only related to the interface and @ES-Alexander was the one to open the issue, I will leave the review of this one to him.

@ES-Alexander
Copy link
Contributor

ES-Alexander commented May 16, 2024

I tried this, and it works and is at least a little more intuitive than the previous behaviour, but it still doesn't feel particularly natural to me, which I think is largely because it's requiring multiple clicks, in different places.

Is it possible to hold to confirm instead? That would better match our existing confirmation mechanisms, and seems more flowy.
I'm thinking ideally we could have either

  1. a circular progress bar that appears around the button (or that the button turns into) while you're holding it, and if you hold it to the end (maybe like 700ms?) then the progress bar turns green and the deletion occurs, but if you stop holding partway through it goes red and it's aborted, with the progress bar disappearing maybe a few hundred milliseconds after the button is released to make the state obvious, or
  2. an expanding bubble that "pops" when it's done (kind of like the chat emoji on messenger), or shrinks back down to the original size if it aborts

That kind of element also seems like it could be reusable, and useful for other confirmation-required actions with on-screen buttons.

We might also want a top-bar notification showing and announcing the result (e.g. "selected videos deleted" (or just a success chime, or crumpling rubbish sound), or "video deletion cancelled" (or a bee-baa cancellation noise)).

@ES-Alexander ES-Alexander changed the title bug: deleting videos isn't working Improve video deletion UI May 16, 2024
@ArturoManzoli
Copy link
Contributor Author

ArturoManzoli commented May 16, 2024

What do you think about a middle ground of keeping the confirmation process with those red and green buttons for now? I'll improve the animation on those to draw users' attention. We can merge and see if there are users who don't adapt to it.

Is it fine for you?

I really like your idea of holding to confirm. It is elegant and minimalist, and that's something I look for in interfaces. For now, the gesture is too uncommon and to use that, we would need to establish a UX philosophy on these gestures, and the whole software should use this approach. Otherwise, people will just click on it and think it's not working.

…icons

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
@rafaellehmkuhl rafaellehmkuhl merged commit 11408df into bluerobotics:master May 17, 2024
8 checks passed
@ArturoManzoli ArturoManzoli deleted the 951-Deleting-videos-isnt-working branch May 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: deleting videos isn't working
3 participants