-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create package publishable to pip #22
Conversation
cdb90dd
to
cf416f0
Compare
cf416f0
to
55b2f68
Compare
bf1bf70
to
f8b1f19
Compare
Is there commits here that are from generator-python.py script ? If so they should be marked as such. Also, individual commits for generated code does not make sense, they should be all together. Should this PR be merged after any PR in ping-protocol ? |
No, things were done manually here and then at the ping-protocol templates.
Yeah, preferably. otherwise I can just discard some of the commits regarding ping1d.py and pingmessage.py |
33d65bf
to
32a6aac
Compare
@jaxxzer can you look at this? I'd like to merge this one before bluerobotics/ping-protocol#106 It is shorter than it looks! |
README.md
Outdated
- Using 'pip' | ||
|
||
```sh | ||
$ pip install bluerobotics-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install bluerobotics-ping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
I think it makes more sense to rebase this on the generated files of bluerobotics/ping-protocol#106. |
I'll do that then, no problem. |
I think we should:
@Williangalvani If you agree, can you take care of #1 |
@jaxxzer sounds good. |
Ok @Williangalvani please take care of the force push here when you are comfortable with it, and I will proceed with the review. You can take care of the current fixups now or after I'm done with the review. |
…26f456041c7cb9976c5d8e0c1
32a6aac
to
a6407ac
Compare
a6407ac
to
3e6bc71
Compare
updated. |
This refactors the packages to follow Python coding guidelines before plublishing.
brping/ping1d.py
andbrping/pingmessage.py
will be rewritten by the script in ping-protocol, updated in bluerobotics/ping-protocol#106Fix #18