ping device simulation

[jaxxzer]

No description provided.

[Williangalvani]

Looks good!
Just a few details.

[jaxxzer]

@Williangalvani done

[patrickelectric]

Also, missing executable permission.

[patrickelectric]

 ✘ patrick@pichau  ~/git/blue/ping-python/brping  ➦ 979e500 ●  pip install bluerobotics-ping --user
Requirement already satisfied: bluerobotics-ping in /home/patrick/.local/lib/python3.7/site-packages (0.0.2)
Requirement already satisfied: pyserial in /usr/lib/python3.7/site-packages (from bluerobotics-ping) (3.4)
 patrick@pichau  ~/git/blue/ping-python/brping  ➦ 979e500 ●  python -m ping1d-simulation 
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/patrick/git/blue/ping-python/brping/ping1d-simulation.py", line 162, in <module>
    sim.sendMessage(PING1D_PROFILE)
  File "/home/patrick/git/blue/ping-python/brping/ping1d-simulation.py", line 76, in sendMessage
    msg.pack_msg_data()
  File "/home/patrick/.local/lib/python3.7/site-packages/brping/pingmessage.py", line 471, in pack_msg_data
    self.msg_data = bytearray(struct.pack(msg_format, *values))
struct.error: pack expected 6 items for packing (got 15)
 ✘ patrick@pichau  ~/git/blue/ping-python/brping  ➦ 979e500 ●  

[jaxxzer]

@patrickelectric use python3

[jaxxzer]

Also, missing executable permission.

$ ls -l brping/
total 108
-rw-r--r-- 1 jack jack    89 Jan 19 12:31 __init__.py
-rw-r--r-- 1 jack jack   211 Jan 24 15:51 __init__.pyc
-rw-r--r-- 1 jack jack 32470 Jan 25 12:22 ping1d.py
-rw-r--r-- 1 jack jack 13607 Jan 24 15:51 ping1d.pyc
-rw-r--r-- 1 jack jack  5975 Jan 28 14:29 ping1d-simulation.py
-rw-r--r-- 1 jack jack 22945 Jan 25 17:19 pingmessage.py
-rw-r--r-- 1 jack jack 13322 Jan 24 15:51 pingmessage.pyc
-rw-r--r-- 1 jack jack  3413 Jan 19 12:31 pingproxy.py

The permission is the same as everything else.

[patrickelectric]

@jaxxzer I'm using.
But ping1d-simulation.py is a program by itself, this one should have +x now ?
@Williangalvani

[patrickelectric]

@jaxxzer Same problem with a fresh arch installation.

[jaxxzer]

@patrickelectric This requires bluerobotics/ping-protocol#118 merge

[patrickelectric]

Ok, this should be tagged in the PR.

[jaxxzer]

I forgot. Now it is.

[jaxxzer]

But ping1d-simulation.py is a program by itself, this one should have +x now ?

#43

[patrickelectric]

You should use env and not python directly.

[patrickelectric]

Python3 only

#!/usr/bin/env python3

or
Python2 only

#!/usr/bin/env python2

or
Both python versions

#!/usr/bin/env python

[patrickelectric]

shebang should use /usr/bin/env and not python directly

[jaxxzer]

shebang should use /usr/bin/env and not python directly

This matches the case in the rest of the repository.
#44

[jaxxzer]

shebang should use /usr/bin/env and not python directly

done