Ping360 firmware update functionality #1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxxzer
force-pushed
the
p360flash-5
branch
6 times, most recently
from
5040c20
to
01e0568
Compare
|
|
||
| void Ping360FlashWorker::run() | ||
| { | ||
| float flashProgressPercentFactor = _verify ? 33.3f : 50.0f; |
There was a problem hiding this comment.
Can you add some explanation about this numbers ?
src/flash/ping360flashworker.cpp
Outdated
| _port = new QSerialPort(); | ||
| QSerialPortInfo pInfo(_link.serialPort()); | ||
| _port->setPort(pInfo); | ||
| _port->setBaudRate(115200); |
There was a problem hiding this comment.
Isn't that supposed to be configured ? Since flasher now has validBaudRates
There was a problem hiding this comment.
yes, there is only one valid baudrate, but yes ✔️
| } | ||
|
|
||
| if (!_port->isOpen()) { | ||
| error("error opening port"); |
There was a problem hiding this comment.
Aren't we supposed to return here ?
jaxxzer
force-pushed
the
p360flash-5
branch
3 times, most recently
from
d94d4dd
to
9a0a885
Compare
jaxxzer
force-pushed
the
p360flash-5
branch
3 times, most recently
from
533f076
to
3a733aa
Compare
…udrate this buadrate is used by default when debug mode is not selected 115200 is the only valid baudrate in common for both supported sensors
the protocol detector functionality is not necessary or used during mannual connection. In fact, the protocol detector scan may interfere with sensor (ping360 bootloader) communication or operation by writing extraneous/ unexpected data. When selecting manual connection, the sensor may be connected without writing unnecessary bytes.
- send requensts when sensor settings struct is valid, this allows adjusting/updating the sensor settings during async scan - reset baudrate to avoid collisions during async profile message transmission - start profile timeout timer to ensure new profile request is received
…han once this allows the logic type to be updated after a firmware update
This is a parameter needed for auto transmit strategy
jaxxzer
force-pushed
the
p360flash-5
branch
6 times, most recently
from
7d49504
to
68fa8b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add firmware update functionality for Ping360.
This is based on top of #1069The bootloader will wait for communication for 2s after powering on before it automatically starts the main application firmware. If the bootloader receives a valid packet, then it will not automatically start the main application.
If the device is stuck in the bootloader (failed programming), the protocol detector and device manager will still identify the device as a ping360 and let you select it. Then there will be a message over the polarplot telling you the device is stuck in the bootloader and asking you to update the firmware.
If the device with valid firmware is plugged in while the protocol detector/device manager is running, then the detector may see the bootloader before the firmware is automatically started. The detector will ask the bootloader to start the main application firmware and all proceeds as normal.