Social proof blocks #2603
Merged
Social proof blocks #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jun 26, 2024
devinivy
reviewed
Jun 26, 2024
devinivy
reviewed
Jun 26, 2024
devinivy
reviewed
Jun 26, 2024
Comment on lines
1067
to
1070
| bidirectionalBlocks: mergeMaps( | ||
| stateA.bidirectionalBlocks, | ||
| stateB.bidirectionalBlocks, | ||
| ), |
There was a problem hiding this comment.
The way bidirectionalBlocks works, I think this would allow some clobbering to happen. For example, how should these two merge?
{ did:example:a -> { did:example:b -> true } }
{ did:example:a -> { did:example:c -> true } }
I think we'd want to find something like this:
{ did:example:a -> { did:example:b -> true, did:example:c -> true } }
As-is I think it would end-up like this, and we'd lose did:example:b:
{ did:example:a -> { did:example:c -> true } }
Co-authored-by: devin ivy <devinivy@gmail.com>
estrattonbailey
commented
Jun 27, 2024
Comment on lines
+28
to
+31
| export const mergeMaps = <V, M extends HydrationMap<V>>( | ||
| mapA?: M, | ||
| mapB?: M, | ||
| ): M | undefined => { |
There was a problem hiding this comment.
@devinivy special note: I axed the Merges interface here so that I could use this more easily within mergeNestedMaps. No change to types or functionality that I can tell, but unsure if I knocked over Chesteron's Fence anywhere else.
There was a problem hiding this comment.
Also general note that I extracted these and made a util.test.ts test
estrattonbailey
added a commit
that referenced
this pull request
Jul 16, 2024
…cements * origin/main: (181 commits) Minor OAuth client fixes (#2640) Version packages (#2639) OAuth: 2FA (#2633) Version packages (#2622) Update data source for `getSuggestedFollowsByActor` (#2630) Add in-memory did cache to Ozone backend (#2635) Filter out reference lists from `getLists` (#2629) lexicons: add missing ozone Tag event type to unions (#2632) ✨ Add ozone proxy for getLikes and getRepostedBy (#2624) Upgrade pnpm/action-setup in workflows (#2625) ✨ Add proxy for user typeahead through ozone (#2612) Fix development commands (#2623) Add starter packs to post hydration (#2613) Social proof blocks (#2603) Appview: apply hosting status in getRecord (#2620) Add `labelersPref` to `getPreferences` union return types (#2554) Version packages (#2618) Add new preference and api for bsky app state; also put preference updates within transactional lock regions (#2492) remove mentions of sandbox (#2611) Appview: simple fix for no-hosted known followers (#2609) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if I follow Daniel, and Daniel follows Devin, but Devin blocks Daniel, when I view Devin's profile I do not see Daniel as part of
knownFollowers.I also extracted some utils and added a few tests + added a new seed specifically for
knownFollowerstesting to handle these 2nd-party blocks more clearly/easily.