Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch worker from server #3

Closed
tacaswell opened this issue Sep 2, 2020 · 1 comment
Closed

Launch worker from server #3

tacaswell opened this issue Sep 2, 2020 · 1 comment
Assignees
Labels
server The core API server worker
Milestone

Comments

@tacaswell
Copy link
Collaborator

The API server should be able to launch / exit / restart the worker process. The worker process should not be externally configure, but should build its state from the information pushed in by the API server. Currently you have to start the plan "manually".

The information pushed in should include (but not limited to):

  • what plans should be available in the namespace
  • what devices should be available in the namespace
  • where to publish the documents to
  • where to publish logs to

Maybe should inculde:

  • where to pull the the "next run id" from

Should not include:

  • user / sample metadata (this belongs to the server and should be pushed in with every plan)

We also should use this to set up a two-way communication between the worker and the server.

Candidates for how to manage the worker process:

  • systemd/supervisord tasks (not quite sure how to do the information injection but I assume it is possible)
  • Subprocess
  • multiprocess.Process

The worker should remain its own process not a thread so we can restart it from the API server, and we may want to eventually run the worker on a different machine than the API server.

@tacaswell tacaswell added worker server The core API server labels Sep 2, 2020
@tacaswell tacaswell added this to the mvp1 milestone Sep 2, 2020
@dmgav dmgav self-assigned this Sep 3, 2020
@dmgav
Copy link
Contributor

dmgav commented Nov 30, 2020

Most of the described features were implemented in PR #29 and improved in multiple following PRs.

@dmgav dmgav closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server The core API server worker
Projects
None yet
Development

No branches or pull requests

2 participants