Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate compatibility with jsonschema 2.x #145

Closed
danielballan opened this issue Feb 18, 2020 · 0 comments · Fixed by #175
Closed

Reinstate compatibility with jsonschema 2.x #145

danielballan opened this issue Feb 18, 2020 · 0 comments · Fixed by #175

Comments

@danielballan
Copy link
Member

In #79 we made bluesky compatible with the new jsonschema 3.x API. We also chose to require that API and become incompatible with 2.x.

Unfortuantely, pip's dependency solver (unlike conda's) does not guarantee satisfying all the dependencies across steps; it just warns when it is going to ignore a pin. It often happens that our jsonschema >=3 pin gets ignored.

It would be simple enough to do a version check on jsonschema at import time and use old-style validation code for jsonschema 2.x. It adds some complexity to our codebase, but given that this issue has come up a couple times and can be puzzling if you don't know what the problem is, I think it's worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant