Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate compatiblity with jsonschema 2.x. #175

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

danielballan
Copy link
Member

@danielballan danielballan commented Jun 2, 2020

Follow-up on #79 which added compatibility for jsonschema 3.x but
broke compatibility for 2.x. In this PR, we support both by defining
schema_validators conditional on the jsonschema version.

Tested by doing a simple bluesky scan.

Closes #145. See that issue for justification.

@danielballan danielballan requested a review from jklynch June 2, 2020 15:09
Copy link
Contributor

@jklynch jklynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

@jklynch jklynch merged commit 577185d into bluesky:master Jun 2, 2020
@danielballan danielballan deleted the jsonschema-2-compat branch June 2, 2020 22:22
@gwbischof gwbischof added this to the 1.15.2 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate compatibility with jsonschema 2.x
3 participants