131 make a simulated detector that can write hdf files #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
requested changes
Apr 4, 2024
coretl
approved these changes
Apr 15, 2024
|
that issue is still present with pyside6 at 6.7.0 |
stan-dot
deleted the
131-make-a-simulated-detector-that-can-write-hdf-files
branch
gilesknap
pushed a commit
to gilesknap/ophyd-async
that referenced
this pull request
Apr 17, 2024
* add the sim module * day progress * more exploration * day's work * incremental changes * an attempt to put features together * incremental changes * try SimSample * make pattern generator do sensible things * make lint happy * attempt at tests * WIP setting up pytest with fake paths * write more test outlines * work on tests * WIP fix async tests * WIP make the tests work better * raw refactor * refactoring proof of concept * delete refactoring attempts * tests improvement * add basic streaming plan * rename to sim driver * change into SimDriver * fix formatting * work on the tests * correct 19 out of 32 errors * down to 10 errors * down to 4 errors, all due to observe_value decision and the NDfileHDF * swmr error * fix lint * setup for asyncio * still error with async * closing writer and file handle issue * move back to pattern generator * got to descriptor validation error * async setup for all IO failed * fix writer descriptor test. also component not found async error * fix the test * pass all tests * ran black * make lint happy * missed one * make mypy happy * fix black * add declare to the failing plan * update pyproject for wrong pyside6 * fix the flyer test * delete mistaken test file * rollback some unintended changes * make lint happy * delete sim sample to lower the test lines * delete empty test * mistake double test * day work (not done yet) * add snake case@ * lock pyside6 to 6.6.2 to fix the svg indent issue in upstream * pyproject syntax error fix
gilesknap
pushed a commit
to gilesknap/ophyd-async
that referenced
this pull request
Apr 17, 2024
* add the sim module * day progress * more exploration * day's work * incremental changes * an attempt to put features together * incremental changes * try SimSample * make pattern generator do sensible things * make lint happy * attempt at tests * WIP setting up pytest with fake paths * write more test outlines * work on tests * WIP fix async tests * WIP make the tests work better * raw refactor * refactoring proof of concept * delete refactoring attempts * tests improvement * add basic streaming plan * rename to sim driver * change into SimDriver * fix formatting * work on the tests * correct 19 out of 32 errors * down to 10 errors * down to 4 errors, all due to observe_value decision and the NDfileHDF * swmr error * fix lint * setup for asyncio * still error with async * closing writer and file handle issue * move back to pattern generator * got to descriptor validation error * async setup for all IO failed * fix writer descriptor test. also component not found async error * fix the test * pass all tests * ran black * make lint happy * missed one * make mypy happy * fix black * add declare to the failing plan * update pyproject for wrong pyside6 * fix the flyer test * delete mistaken test file * rollback some unintended changes * make lint happy * delete sim sample to lower the test lines * delete empty test * mistake double test * day work (not done yet) * add snake case@ * lock pyside6 to 6.6.2 to fix the svg indent issue in upstream * pyproject syntax error fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.