Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in callback_on_mock_put #321

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix typing in callback_on_mock_put #321

merged 2 commits into from
May 22, 2024

Conversation

dperl-dls
Copy link
Contributor

callback_on_mock_put had an incorrect type annotation which was causing some errors, removing it lets the type checker correctly note it as:

(function) def callback_on_mock_put(
    signal: Signal[Unknown],
    callback: (T@callback_on_mock_put) -> None
) -> _GeneratorContextManager[None]

@dperl-dls dperl-dls requested a review from evalott100 May 20, 2024 15:39
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dperl-dls dperl-dls merged commit 9ca7249 into main May 22, 2024
18 checks passed
@dperl-dls dperl-dls deleted the mock_context_fix_typing branch May 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants