Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in callback_on_mock_put #321

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix typing in callback_on_mock_put #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5960f7a
Fix typing in callback_on_mock_put
dperl-dls May 20, 2024
eae7006
Merge branch 'main' into mock_context_fix_typing
dperl-dls May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/ophyd_async/core/mock_signal_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from contextlib import asynccontextmanager, contextmanager
from typing import Any, Callable, Generator, Iterable, Iterator, List
from typing import Any, Callable, Iterable, Iterator, List
from unittest.mock import ANY, Mock

from ophyd_async.core.signal import Signal
Expand Down Expand Up @@ -127,11 +127,7 @@ def _unset_side_effect_cm(put_mock: Mock):
put_mock.side_effect = None


# linting isn't smart enought to realize @contextmanager will give use a
# ContextManager[None]
def callback_on_mock_put(
signal: Signal, callback: Callable[[T], None]
) -> Generator[None, None, None]:
def callback_on_mock_put(signal: Signal, callback: Callable[[T], None]):
"""For setting a callback when a backend is put to.

Can either be used in a context, with the callback being
Expand Down