Implement bluetooth mesh support #60

dejanb · 2022-11-23T12:25:15Z

This is an initial implementation of the support for Bluetooth mesh API as discussed in issue #37

It supports at the moment:

Joining and provisioning mesh networks
Sending and receiving messages

Some functionalities that are not implemented yet:

Scanning
Importing/Exporting
Managing keys

Currently implemented features are quite stable and we used them to implement the gateway for the EclipseCon Hackathon. They should be a good base for the further development.

The implementation depends on the btmesh crate for representing Bluetooth mesh models. We'll release this crate shortly, so that git dependency can be removed.

Please let me know if you have any further questions about this. Any feedback is more than welcomed.

surban

Thanks for making the effort to implement support for mesh networks!

However, a bit more work is required before I can merge this.

The main issue is the exposure of D-Bus paths, which we treat as internals in BlueR. See how the GATT server is implemented on how to do it without exposing D-Bus paths to the user.

Also we target stable Rust, thus you must remove the use of nightly features. However, we can bump the minimum supported Rust version to the newest stable version, so GATs should be usable by now.

In general, a bit more documentation is required. Explain what the functions do from the Bluetooth side of things and how they interact.

I haven't tested your code yet. Please make the above changes and then I will have a more in-depth look and provide further comments.

Also, what would I require for testing? Would it be possible to make a Bluetooth Mesh out of some Raspberry Pis?

bluer/src/mesh/agent.rs

bluer/src/mesh/application.rs

surban · 2022-12-15T10:21:31Z

bluer/src/mesh/application.rs

+    pub version: u16,
+}
+
+impl Default for Properties {


Do not provide such defaults for identifiers that should be unique.

bluer/src/mesh/application.rs

bluer/src/mesh/types.rs

bluer/src/lib.rs

bluer/Cargo.toml

surban · 2022-12-15T11:15:24Z

bluer/examples/mesh_provisioner.rs

@@ -0,0 +1,168 @@
+#![feature(generic_associated_types)]
+//! Attach and send/receive BT Mesh messages


Would this be useful as a standalone tool?
Then consider moving it to bluer-tools and properly documenting the CLI arguments.

No, this is just an example for now (as it is tied to the predefined model) ... The proper tool needs more work

surban · 2022-12-15T11:16:04Z

bluer-tools/Cargo.toml

@@ -46,3 +46,4 @@ libc = "0.2"
 log = "0.4"
 hex = { version = "0.4" }
 rand = "0.8"
+uuid = { version = "1", features = ["v4"] }


not necessary

surban

Thanks for making the effort to implement support for mesh networks!

However, a bit more work is required before I can merge this.

The main issue is the exposure of D-Bus paths, which we treat as internals in BlueR. See how the GATT server is implemented on how to do it without exposing D-Bus paths to the user.

Also we target stable Rust, thus you must remove the use of nightly features. However, we can bump the minimum supported Rust version to the newest stable version, so GATs should be usable by now.

In general, a bit more documentation is required. Explain what the functions do from the Bluetooth side of things and how they interact.

I haven't tested your code yet. Please make the above changes and then I will have a more in-depth look and provide further comments.

Also, what would I require for testing? Would it be possible to make a Bluetooth Mesh out of some Raspberry Pis?

dejanb · 2022-12-16T12:34:21Z

Thanks for reviewing it and the valuable feedback, I'll start addressing the particular comments in the coming days. I was expecting some work to be done before the merge. I was developing it to meet our demo needs for a while and now that it looks stable to me, it made sense to continue development within the bluer project umbrella.

As for the testing, yes you can use rPi (or any other bluetooth-enabled Linux machine) to run and test everything. The descriptions in the examples should get you going

bluer/bluer/examples/mesh_sensor_client.rs

Line 4 in fb099a7

//! Example meshd

# This is the 1st commit message: BLE Passive Scanning # This is the commit message #2: monitor # This is the commit message bluez#3: monitor # This is the commit message bluez#4: monitor # This is the commit message bluez#5: monitor # This is the commit message bluez#6: monitor # This is the commit message bluez#7: monitor # This is the commit message bluez#8: monitor # This is the commit message bluez#9: monitor # This is the commit message bluez#10: monitor # This is the commit message bluez#11: monitor # This is the commit message bluez#12: monitor # This is the commit message bluez#13: monitor # This is the commit message bluez#14: monitor # This is the commit message bluez#15: monitor # This is the commit message bluez#16: monitor # This is the commit message bluez#17: monitor # This is the commit message bluez#18: monitor # This is the commit message bluez#19: monitor # This is the commit message bluez#20: monitor # This is the commit message bluez#21: monitor # This is the commit message bluez#22: monitor # This is the commit message bluez#23: monitor # This is the commit message bluez#24: monitor # This is the commit message bluez#25: monitor # This is the commit message bluez#26: monitor # This is the commit message bluez#27: monitor # This is the commit message bluez#28: monitor # This is the commit message bluez#29: monitor # This is the commit message bluez#30: monitor # This is the commit message bluez#31: monitor # This is the commit message bluez#32: monitor # This is the commit message bluez#33: monitor # This is the commit message bluez#34: monitor # This is the commit message bluez#35: monitor # This is the commit message bluez#36: monitor # This is the commit message bluez#37: monitor # This is the commit message bluez#38: monitor # This is the commit message bluez#39: monitor # This is the commit message bluez#40: monitor # This is the commit message bluez#41: monitor # This is the commit message bluez#42: monitor # This is the commit message bluez#43: monitor # This is the commit message bluez#44: monitor # This is the commit message bluez#45: monitor # This is the commit message bluez#46: monitor # This is the commit message bluez#47: monitor # This is the commit message bluez#48: monitor # This is the commit message bluez#49: monitor # This is the commit message bluez#50: monitor # This is the commit message bluez#51: monitor # This is the commit message bluez#52: monitor # This is the commit message bluez#53: monitor # This is the commit message bluez#54: monitor # This is the commit message bluez#55: monitor # This is the commit message bluez#56: monitor # This is the commit message bluez#57: monitor # This is the commit message bluez#58: monitor # This is the commit message bluez#59: monitor # This is the commit message bluez#60: monitor # This is the commit message bluez#61: monitor # This is the commit message bluez#62: monitor

surban · 2023-06-20T10:17:52Z

I've revised the Pull Request to align with BlueR's API style and am preparing to merge it now.

I've eliminated the dependency on the btmesh-* crates temporarily. This means message generation and parsing responsibilities will now fall on the user. In my view, an optimal solution would be to introduce extension traits in btmesh for the BlueR types Node and ReceivedMessage. This would then facilitate message generation and parsing via these traits. As such, BlueR would solely manage the API-surface exposed by BlueZ, treating mesh messages as binary data.

For the time being, the mesh examples have been deactivated. Could you kindly update them and submit a follow-up PR?

dejanb · 2023-06-23T09:21:48Z

@surban Thanks for picking it up ... My work priorities shifted lately and I didn't have time to commit to it.

I'll try to introduce btmesh through extension traits as you suggested and make examples work again.

surban self-requested a review December 14, 2022 18:57

surban self-assigned this Dec 14, 2022

surban requested changes Dec 15, 2022

View reviewed changes

surban added the enhancement New feature or request label Dec 15, 2022

dejanb and others added 11 commits March 14, 2023 12:23

Implement bluetooth mesh support

26f55a6

Remove usage uf dbus paths from the application code

f94de1c

Support callback functions for the agent

c82fca8

Remove nightly features

ee35298

Rename FromDrogue struct

bc2a554

Remove usage uf dbus paths from the application code

6f92bec

remove unused traits and simplify model usage

2dd90b1

Adopt other example to the new models usage

edbec54

Move meshd configuration to examples

7515608

Improve documentation

092ab9c

Fix examples

38436f0

dejanb force-pushed the mesh-final branch from 62fa4f6 to 38436f0 Compare March 14, 2023 16:24

surban linked an issue Jun 13, 2023 that may be closed by this pull request

Implement Mesh API #37

Closed

surban added 4 commits June 14, 2023 12:02

Merge branch 'master' into pr/dejanb/60

2e52bd4

Code formatting

575b8f4

Rework Bluetooth mesh support

146c235

Fix clippy warnings.

d1045c2

surban merged commit 1173222 into bluez:master Jun 20, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement bluetooth mesh support #60

Implement bluetooth mesh support #60

dejanb commented Nov 23, 2022 •

edited

Loading

surban left a comment

surban Dec 15, 2022

surban Dec 15, 2022

dejanb Mar 10, 2023

surban Dec 15, 2022

surban left a comment

dejanb commented Dec 16, 2022

surban commented Jun 20, 2023

dejanb commented Jun 23, 2023

		@@ -0,0 +1,168 @@
		#![feature(generic_associated_types)]
		//! Attach and send/receive BT Mesh messages

Implement bluetooth mesh support #60

Implement bluetooth mesh support #60

Conversation

dejanb commented Nov 23, 2022 • edited Loading

surban left a comment

Choose a reason for hiding this comment

surban Dec 15, 2022

Choose a reason for hiding this comment

surban Dec 15, 2022

Choose a reason for hiding this comment

dejanb Mar 10, 2023

Choose a reason for hiding this comment

surban Dec 15, 2022

Choose a reason for hiding this comment

surban left a comment

Choose a reason for hiding this comment

dejanb commented Dec 16, 2022

surban commented Jun 20, 2023

dejanb commented Jun 23, 2023

dejanb commented Nov 23, 2022 •

edited

Loading