Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combo names on slider name change #72

Open
tbttfox opened this issue Jan 10, 2018 · 3 comments
Open

Update combo names on slider name change #72

tbttfox opened this issue Jan 10, 2018 · 3 comments
Labels

Comments

@tbttfox
Copy link
Member

tbttfox commented Jan 10, 2018

Update combo names on slider name change

@tbttfox tbttfox added the bug label Jan 10, 2018
@illmillrig
Copy link

we have a change for this if you're interested

@tbttfox
Copy link
Member Author

tbttfox commented Jan 8, 2021

Yeah, send it this way!

Just wondering how deep you went into this? I've got this Big Idea for a web of interconnected names, but honestly any step forward helps.


My Big Idea is that changing a slider name could change a combo, or any of its underlying shapes. Changing a combo could change its underlying shapes, and even back-propagate to the slider which could change other combos.
Changing a shape name could change its parent slider name which could change other shape names, and on down the line.

There are currently some unused functions in the UI code that start to deal with all that. And eventually, my plan was to have a UI optionally pop up on name change to be able to conditionally approve any downstream renames

@illmillrig
Copy link

It was a really minor change, you had a todo note in the setter for slider.name to also update the combo names

so i added

for combo in self.simplex.getDownstreamCombos(self):
    combo.updateName()

and

def updateName(self):
    values = [p.value for p in self.pairs]
    name = self.buildComboName(self.getSliders(), values)
    self.name = name

of course please feel free to offer any advice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants