Adding reverse() to IndexMap & IndexSet
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linclelinkpart5
changed the title
remove() to IndexMap & IndexSet #127remove() to IndexMap & IndexSet
cuviper
reviewed
Jun 8, 2020
cuviper
changed the title
remove() to IndexMap & IndexSetreverse() to IndexMap & IndexSet
|
Please update the PR description to close the feature request with a keyword https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword thanks |
|
Special thanks for using quickcheck |
|
Thanks all! And no problem @bluss, it was fun to work with. It inspired me to look into it for testing my current project, so it's a win-win! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127.
Here's my work so far, just basing it off of what's done in
sort_by(). Happy to include the more efficient re-indexing as you suggested, @cuviper! Just need to learn how.