Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Python 3.7 and 3.8 compatibility #2

Closed
aaronwmorris opened this issue Feb 24, 2024 · 2 comments
Closed

Python 3.7 and 3.8 compatibility #2

aaronwmorris opened this issue Feb 24, 2024 · 2 comments

Comments

@aaronwmorris
Copy link
Contributor

aaronwmorris commented Feb 24, 2024

Python 3.7 and 3.8 do not support built-in collections for type hints for lists and tuples with parameters.

On Python 3.7, the fish2pano 0.4.0 results in the following exception:

...
  File "/home/aaron/git/indi-allsky/indi_allsky/processing.py", line 2489, in fish2pano_module
    import fish2pano
  File "/home/aaron/git/indi-allsky/virtualenv/indi-allsky/lib/python3.7/site-packages/fish2pano/__init__.py", line 46, in <module>
    def fish2pano(img_raw: np.ndarray, radius: float, center: list[int, int], scale: float):
TypeError: 'type' object is not subscriptable
@aaronwmorris
Copy link
Contributor Author

Submitted PR #1 to fix

@bluthen
Copy link
Owner

bluthen commented Feb 26, 2024

Thanks! Sorry for not testing 3.7 better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants