Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Readdir errors reset glob results #43

Closed
ghost opened this issue Aug 14, 2020 · 2 comments
Closed

[bug] Readdir errors reset glob results #43

ghost opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Aug 14, 2020

Hi,
a change was introduced in 1.30 to return the error from readdir, but this change is causing the glob results to get corrupted due to nil getting returned and overwriting all previous glob results.

https://github.com/bmatcuk/doublestar/blob/master/doublestar.go#L452

From what I can tell the line should just return rather than return nil, err.

@bmatcuk bmatcuk self-assigned this Aug 15, 2020
@bmatcuk bmatcuk added the bug label Aug 15, 2020
@bmatcuk
Copy link
Owner

bmatcuk commented Aug 15, 2020

Yup, I agree with that assessment! I've cut a new version of both v1 (v1.3.2) and v2 (v2.0.1) with the fix. Let me know if that solves the problem for you!

@ghost
Copy link
Author

ghost commented Aug 16, 2020

Yup, I agree with that assessment! I've cut a new version of both v1 (v1.3.2) and v2 (v2.0.1) with the fix. Let me know if that solves the problem for you!

It absolutely does, thanks for the quick response!

@ghost ghost closed this as completed Aug 16, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant