Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite mudabox to use JObject semantics for serialization #12

Closed
bmcfee opened this issue Mar 26, 2015 · 0 comments
Closed

rewrite mudabox to use JObject semantics for serialization #12

bmcfee opened this issue Mar 26, 2015 · 0 comments

Comments

@bmcfee
Copy link
Owner

bmcfee commented Mar 26, 2015

Currently, muda.save is a destructive operation: when the jam is serialized, we first pop out the audio buffer jam.sandbox.muda['y'] to avoid serializing the audio. This is obviously bad.

JObject serialization already skips fields that start with _.

A simple fix here would be the following:

  • Modify jam_pack to construct muda as a JObject (or Sandbox) rather than a dict
  • Push the audio content down a level, ie, muda._audio['y'] and muda._audio['sr']
  • Modify all deformation logic accordingly

This way, muda._audio will be skipped during serialization, and save can be a non-destructive operation.

@bmcfee bmcfee closed this as completed Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant