You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, muda.save is a destructive operation: when the jam is serialized, we first pop out the audio buffer jam.sandbox.muda['y'] to avoid serializing the audio. This is obviously bad.
JObject serialization already skips fields that start with _.
A simple fix here would be the following:
Modify jam_pack to construct muda as a JObject (or Sandbox) rather than a dict
Push the audio content down a level, ie, muda._audio['y'] and muda._audio['sr']
Modify all deformation logic accordingly
This way, muda._audio will be skipped during serialization, and save can be a non-destructive operation.
The text was updated successfully, but these errors were encountered:
Currently,
muda.save
is a destructive operation: when the jam is serialized, we first pop out the audio bufferjam.sandbox.muda['y']
to avoid serializing the audio. This is obviously bad.JObject serialization already skips fields that start with
_
.A simple fix here would be the following:
jam_pack
to constructmuda
as a JObject (or Sandbox) rather than a dictmuda._audio['y']
andmuda._audio['sr']
This way,
muda._audio
will be skipped during serialization, and save can be a non-destructive operation.The text was updated successfully, but these errors were encountered: