Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old jams BackgroundNoise lacking start and stop #79

Open
grudloff opened this issue May 30, 2020 · 3 comments
Open

Old jams BackgroundNoise lacking start and stop #79

grudloff opened this issue May 30, 2020 · 3 comments

Comments

@grudloff
Copy link

Hello!

I am reproducing a paper by Salomon & Bello, and need to make transformations according to the jams files in UrbanSound8K-JAMS, for which I am using muda.replay().

It seems that they used a previous version of Background noise which didn't use start and stop parameters, probably prior to this commit. I am thinking of just setting a default value for the case where there is no start and stop in the status, something like this:

try:
     start = state['start']
     stop = state['stop']
except  KeyError:
     start = 0
     stop = len(mudabox._audio['y'])

I will post if this works fine latter on. Would appreciate some feedback on this.

@grudloff grudloff changed the title Old jams BackgroundNoise lacking start and end Old jams BackgroundNoise lacking start and stop May 31, 2020
@grudloff
Copy link
Author

Just thought about it again and I think the best is just to downgrade to an old version. I will leave this here anyways in case someone else stumbles with this issue.

@bmcfee
Copy link
Owner

bmcfee commented Jun 5, 2020

Thanks for noting that! I agree that rolling back is probably the easiest solution here.

@grudloff
Copy link
Author

Hello! Thanks for your kind response! In the end I opted for making a fork and rolling back only the background.py file. I will leave the link here in case it is useful for anyone. link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants