Merge pull request #25 from keithamus/fix-24-add-cookieaccessinfo-all

feat: add CookieAccessInfo.All sentinel
bmeck · Jul 12, 2016 · c9c3a0c · c9c3a0c
2 parents 3c3d43c + a0a4cbd
commit c9c3a0c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cookiejar.js b/cookiejar.js
@@ -12,6 +12,7 @@
         }
         return new CookieAccessInfo(domain, path, secure, script);
     }
+    CookieAccessInfo.All = Object.freeze(Object.create(null));
     exports.CookieAccessInfo = CookieAccessInfo;
 
     function Cookie(cookiestr, request_domain, request_path) {
@@ -118,6 +119,9 @@
     };
 
     Cookie.prototype.matches = function matches(access_info) {
+        if (access_info === CookieAccessInfo.All) {
+          return true;
+        }
         if (this.noscript && access_info.script ||
                 this.secure && !access_info.secure ||
                 !this.collidesWith(access_info)) {

diff --git a/tests/test.js b/tests/test.js
@@ -80,3 +80,8 @@ assert.equal(cookie.path, "/accounts");
 test_jar.setCookie(new Cookie("sub=5;path=/", "test.com", "/accounts"));
 var cookies = test_jar.getCookies(CookieAccessInfo("test.com"));
 assert.equal(cookies.length, 3);
+
+test_jar.setCookie(new Cookie("sub=5;path=/", "test.com", "/accounts"));
+var cookie = test_jar.getCookie('sub', CookieAccessInfo.All);
+assert(cookie);
+assert.equal(cookie.name, 'sub');