feat: add CookieAccessInfo.All sentinel #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmeck any update on this? |
| @@ -12,6 +12,7 @@ | |||
| } | |||
| return new CookieAccessInfo(domain, path, secure, script); | |||
| } | |||
| CookieAccessInfo.All = Object.freeze({}); | |||
There was a problem hiding this comment.
Object.freeze(Object.create(null)) if you would please, if you want a unique value, that is not a Symbol, create from null.
|
@keithamus change to use |
This allows for fetching cookies with any access info, useful for tests. Fixes bmeck#24
keithamus
force-pushed
the
fix-24-add-cookieaccessinfo-all
branch
from
577c626
to
a0a4cbd
Compare
|
@bmeck done and done 😄 |
|
merged, will publish to npm after a couple meetings |
|
Published using f7c331b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for fetching cookies with any access info, useful for tests.
Fixes #24. Refs chaijs/chai-http#43
Sorry this has taken a while to get done @bmeck