Skip to content

Commit

Permalink
- Removed test-unit dependency
Browse files Browse the repository at this point in the history
- updated minitest to 5.0
- Removed Test::Unit::TestCase and started using Minitest::Test instead
- Fixed usage of assert_raise
- Fixed usage of refute_nil
- Fixed and removed usage of assert_nothing_raised
  • Loading branch information
vipulnsward committed Jan 10, 2015
1 parent 5f6168b commit 23c2e19
Show file tree
Hide file tree
Showing 59 changed files with 129 additions and 128 deletions.
6 changes: 1 addition & 5 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if RUBY_ENGINE == 'jruby'
end

if RUBY_ENGINE == "ruby" and RUBY_VERSION > '1.9.2'
gem "minitest", "~> 4.0"
gem "minitest", "~> 5.0"
gem 'less', '~> 2.0'
gem 'therubyracer'
gem 'redcarpet'
Expand Down Expand Up @@ -65,10 +65,6 @@ if RUBY_ENGINE == "ruby" and RUBY_VERSION > '1.9.2'
gem 'sass'
end

if RUBY_ENGINE == "ruby" and RUBY_VERSION > '2.1'
gem 'test-unit', '~> 3.0'
end

if RUBY_ENGINE == "rbx"
gem 'json'
gem 'rubysl'
Expand Down
4 changes: 2 additions & 2 deletions README.de.md
Original file line number Diff line number Diff line change
Expand Up @@ -2387,10 +2387,10 @@ wird empfohlen:

```ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'
class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods
def app
Expand Down
4 changes: 2 additions & 2 deletions README.es.md
Original file line number Diff line number Diff line change
Expand Up @@ -2215,10 +2215,10 @@ cualquier framework o librería de pruebas basada en Rack. Se recomienda usar

``` ruby
require 'mi_app_sinatra'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MiAppTest < Test::Unit::TestCase
class MiAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.fr.md
Original file line number Diff line number Diff line change
Expand Up @@ -2394,10 +2394,10 @@ recommandé :

``` ruby
require 'mon_application_sinatra'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MonTest < Test::Unit::TestCase
class MonTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
2 changes: 1 addition & 1 deletion README.hu.md
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ könyvtárat ajánljuk:
require 'my_sinatra_app'
require 'rack/test'

class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.ja.md
Original file line number Diff line number Diff line change
Expand Up @@ -2198,10 +2198,10 @@ SinatraでのテストはRackベースのテストライブラリまたはフレ

``` ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.ko.md
Original file line number Diff line number Diff line change
Expand Up @@ -2373,10 +2373,10 @@ Sinatra 테스트는 많은 Rack 기반 테스팅 라이브러리, 프레임워

``` ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2421,10 +2421,10 @@ is recommended:
``` ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'
class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods
def app
Expand Down
2 changes: 1 addition & 1 deletion README.pt-br.md
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ framework de teste baseados no Rack.
require 'minha_aplicacao_sinatra'
require 'rack/test'

class MinhaAplicacaoTeste < Test::Unit::TestCase
class MinhaAplicacaoTeste < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
2 changes: 1 addition & 1 deletion README.pt-pt.md
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ framework de teste baseados no Rack.
require 'minha_aplicacao_sinatra'
require 'rack/test'

class MinhaAplicacaoTeste < Test::Unit::TestCase
class MinhaAplicacaoTeste < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.ru.md
Original file line number Diff line number Diff line change
Expand Up @@ -2304,10 +2304,10 @@ Rack распространяется с различными стандартн

```ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions README.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -1701,10 +1701,10 @@ Sinatra的测试可以使用任何基于Rack的测试程序库或者框架来编

~~~~ ruby
require 'my_sinatra_app'
require 'test/unit'
require 'minitest/autorun'
require 'rack/test'

class MyAppTest < Test::Unit::TestCase
class MyAppTest < Minitest::Test
include Rack::Test::Methods

def app
Expand Down
4 changes: 2 additions & 2 deletions test/asciidoctor_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
begin
require 'asciidoctor'

class AsciidoctorTest < Test::Unit::TestCase
class AsciidoctorTest < Minitest::Test
def asciidoc_app(&block)
mock_app do
set :views, File.dirname(__FILE__) + '/views'
Expand Down Expand Up @@ -33,7 +33,7 @@ def asciidoc_app(&block)

it 'raises error if template not found' do
mock_app { get('/') { asciidoc :no_such_template } }
assert_raise(Errno::ENOENT) { get('/') }
assert_raises(Errno::ENOENT) { get('/') }
end

it 'renders with inline layouts' do
Expand Down
2 changes: 1 addition & 1 deletion test/base_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path('../helper', __FILE__)

class BaseTest < Test::Unit::TestCase
class BaseTest < Minitest::Test
describe 'Sinatra::Base subclasses' do
class TestApp < Sinatra::Base
get('/') { 'Hello World' }
Expand Down
4 changes: 2 additions & 2 deletions test/builder_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
begin
require 'builder'

class BuilderTest < Test::Unit::TestCase
class BuilderTest < Minitest::Test
def builder_app(options = {}, &block)
mock_app do
set :views, File.dirname(__FILE__) + '/views'
Expand Down Expand Up @@ -82,7 +82,7 @@ def builder_app(options = {}, &block)
mock_app do
get('/') { builder :no_such_template }
end
assert_raise(Errno::ENOENT) { get('/') }
assert_raises(Errno::ENOENT) { get('/') }
end
end

Expand Down
4 changes: 2 additions & 2 deletions test/coffee_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
raise LoadError, 'unable to execute JavaScript'
end

class CoffeeTest < Test::Unit::TestCase
class CoffeeTest < Minitest::Test
def coffee_app(options = {}, &block)
mock_app do
set :views, File.dirname(__FILE__) + '/views'
Expand Down Expand Up @@ -65,7 +65,7 @@ def coffee_app(options = {}, &block)
mock_app {
get('/') { coffee :no_such_template }
}
assert_raise(Errno::ENOENT) { get('/') }
assert_raises(Errno::ENOENT) { get('/') }
end

it "passes coffee options to the coffee engine" do
Expand Down
2 changes: 1 addition & 1 deletion test/compile_test.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# I like coding: UTF-8
require File.expand_path('../helper', __FILE__)

class CompileTest < Test::Unit::TestCase
class CompileTest < Minitest::Test

def self.converts pattern, expected_regexp
it "generates #{expected_regexp.source} from #{pattern}" do
Expand Down
15 changes: 3 additions & 12 deletions test/contest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,15 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
require "test/unit"

# Test::Unit loads a default test if the suite is empty, whose purpose is to
# fail. Since having empty contexts is a common practice, we decided to
# overwrite TestSuite#empty? in order to allow them. Having a failure when no
# tests have been defined seems counter-intuitive.
class Test::Unit::TestSuite
def empty?
false
end
end
require "rubygems"
require "minitest/autorun"

# Contest adds +teardown+, +test+ and +context+ as class methods, and the
# instance methods +setup+ and +teardown+ now iterate on the corresponding
# blocks. Note that all setup and teardown blocks must be defined with the
# block syntax. Adding setup or teardown instance methods defeats the purpose
# of this library.
class Test::Unit::TestCase
class Minitest::Test
def self.setup(&block) setup_blocks << block end
def self.teardown(&block) teardown_blocks << block end
def self.setup_blocks() @setup_blocks ||= [] end
Expand Down
4 changes: 2 additions & 2 deletions test/creole_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
begin
require 'creole'

class CreoleTest < Test::Unit::TestCase
class CreoleTest < Minitest::Test
def creole_app(&block)
mock_app do
set :views, File.dirname(__FILE__) + '/views'
Expand All @@ -26,7 +26,7 @@ def creole_app(&block)

it "raises error if template not found" do
mock_app { get('/') { creole :no_such_template } }
assert_raise(Errno::ENOENT) { get('/') }
assert_raises(Errno::ENOENT) { get('/') }
end

it "renders with inline layouts" do
Expand Down
2 changes: 1 addition & 1 deletion test/delegator_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path('../helper', __FILE__)

class DelegatorTest < Test::Unit::TestCase
class DelegatorTest < Minitest::Test
class Mirror
attr_reader :last_call
def method_missing(*a, &b)
Expand Down
2 changes: 1 addition & 1 deletion test/encoding_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require File.expand_path('../helper', __FILE__)
require 'erb'

class BaseTest < Test::Unit::TestCase
class BaseTest < Minitest::Test
setup do
@base = Sinatra.new(Sinatra::Base)
@base.set :views, File.dirname(__FILE__) + "/views"
Expand Down
2 changes: 1 addition & 1 deletion test/erb_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path('../helper', __FILE__)

class ERBTest < Test::Unit::TestCase
class ERBTest < Minitest::Test
def engine
Tilt::ERBTemplate
end
Expand Down
2 changes: 1 addition & 1 deletion test/extensions_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path('../helper', __FILE__)

class ExtensionsTest < Test::Unit::TestCase
class ExtensionsTest < Minitest::Test
module FooExtensions
def foo
end
Expand Down
4 changes: 2 additions & 2 deletions test/filter_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path('../helper', __FILE__)

class BeforeFilterTest < Test::Unit::TestCase
class BeforeFilterTest < Minitest::Test
it "executes filters in the order defined" do
count = 0
mock_app do
Expand Down Expand Up @@ -176,7 +176,7 @@ class BeforeFilterTest < Test::Unit::TestCase
end
end

class AfterFilterTest < Test::Unit::TestCase
class AfterFilterTest < Minitest::Test
it "executes before and after filters in correct order" do
invoked = 0
mock_app do
Expand Down
4 changes: 2 additions & 2 deletions test/haml_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
begin
require 'haml'

class HAMLTest < Test::Unit::TestCase
class HAMLTest < Minitest::Test
def haml_app(&block)
mock_app do
set :views, File.dirname(__FILE__) + '/views'
Expand Down Expand Up @@ -42,7 +42,7 @@ def haml_app(&block)

it "raises error if template not found" do
mock_app { get('/') { haml :no_such_template } }
assert_raise(Errno::ENOENT) { get('/') }
assert_raises(Errno::ENOENT) { get('/') }
end

it "passes HAML options to the Haml engine" do
Expand Down
10 changes: 8 additions & 2 deletions test/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,19 @@
libdir = File.dirname(File.dirname(__FILE__)) + '/lib'
$LOAD_PATH.unshift libdir unless $LOAD_PATH.include?(libdir)

require 'minitest'
require 'contest'
require 'rack/test'
require 'sinatra/base'

class Sinatra::Base
include Minitest::Assertions
# Allow assertions in request context
include Test::Unit::Assertions
def assertions
@assertions ||= 0
end

attr_writer :assertions
end

class Rack::Builder
Expand All @@ -33,7 +39,7 @@ def include?(middleware)

Sinatra::Base.set :environment, :test

class Test::Unit::TestCase
class Minitest::Test
include Rack::Test::Methods

class << self
Expand Down
Loading

0 comments on commit 23c2e19

Please sign in to comment.