Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking of deleted saveframes, and a menu to un-delete them #53

Closed
jonwedell opened this issue Jan 11, 2019 · 4 comments
Closed

Add tracking of deleted saveframes, and a menu to un-delete them #53

jonwedell opened this issue Jan 11, 2019 · 4 comments
Assignees
Labels
pending verification Fixed, but pending confirmation in testing.

Comments

@jonwedell
Copy link
Member

Stop actually deleting them, and instead mark them as deleted. Then don't emit them during submission if deleted.

@rsiegl
Copy link
Contributor

rsiegl commented Jan 29, 2019

I can confirm that the deleting and restoring of the saveframes works.

When a section is deleted the page says "No matching saveframes... that exists." You can still access this page by using the previous and next category buttons (the page still just says no matching saveframes etc.). I am not sure if we want to have it just skip over this page and onto the next saveframe or if we want to have a different page present. Just something I noticed while deleting saveframes.

@jonwedell
Copy link
Member Author

Ah yeah, this behavior is somewhat buggy. I'll tweak it.

Do you think we should still show where a category would be, but say that it has been deleted and offer the option to restore? Or should we actually hide deleted sections, and force users to go to the restore menu to recover them?

jonwedell pushed a commit that referenced this issue Jan 30, 2019
… option to restore all saveframes of that category. #53
jonwedell pushed a commit that referenced this issue Jan 30, 2019
@jonwedell
Copy link
Member Author

The behavior should be more like what you expect now. It automatically redirects to the next category if you delete the last of a saveframe in a category.

@rsiegl
Copy link
Contributor

rsiegl commented Jan 31, 2019

Yeah I can confirm that works now.

My initial thoughts on what to do with the deleted sections would be to make a sub-section under the Deposition Contents section (like the "Experimental descriptions" or the "NMR parameters") and title it "Deleted saveframes". This way the user could directly see all of the saveframes they have deleted rather than having to go into Deposition Options then Restore deleted saveframes then scroll through to find a desired saveframe that was deleted. This deleted saveframes sub-section could be used in the submission process as a final check (in the sense that the user would have to confirm their deletions prior to submitting the entry).

jonwedell pushed a commit that referenced this issue Aug 24, 2020
…aveframes. Make a bunch of changes all over to get everything to play nice. Replace saveframe.deleted() with a calculated-on-updated "deleted" property to improve efficiency. Added a link to the restore menu on the left panel. Closes #53.
jonwedell pushed a commit that referenced this issue Aug 24, 2020
… option to restore all saveframes of that category. #53
jonwedell pushed a commit that referenced this issue Aug 24, 2020
jonwedell added a commit that referenced this issue Aug 24, 2020
…aveframes. Make a bunch of changes all over to get everything to play nice. Replace saveframe.deleted() with a calculated-on-updated "deleted" property to improve efficiency. Added a link to the restore menu on the left panel. Closes #53.
jonwedell added a commit that referenced this issue Aug 24, 2020
… option to restore all saveframes of that category. #53
jonwedell added a commit that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending verification Fixed, but pending confirmation in testing.
Projects
None yet
Development

No branches or pull requests

2 participants