Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Required Sections #50

Closed
rsiegl opened this issue Jan 11, 2019 · 3 comments
Closed

Deleting Required Sections #50

rsiegl opened this issue Jan 11, 2019 · 3 comments

Comments

@rsiegl
Copy link
Contributor

rsiegl commented Jan 11, 2019

If you go to the sample page, which is a required field, you have the option to hit delete. Upon doing so it removes the page from the sidebar menu and you cannot access it from the next/previous category buttons either. Immediately after deleting the selection the following appears "No matching saveframes found in this entry. Click here to return to a category that exists." This can be done for any page that has the delete option at the top and I have yet to find a way to recover the deleted sections. I think these pages should be like the Citations and Molecular entity page where the first block does not have a delete option, but subsequent ones do.

@rsiegl
Copy link
Contributor Author

rsiegl commented Jan 11, 2019

This also removes the deleted sections from the downloaded and/or completed entry as you could assume.

@jonwedell
Copy link
Member

We discussed this in person, but to make a record for posterity:

This is actually defined in the dictionary: some saveframes are mandatory (and therefore cannot be deleted) and others are not. In theory, you could have a theoretical experiment with no sample. Therefore all the behavior to hide deleted saveframes is proper and on purpose.

What is needed though, is a way to restore accidentally-deleted saveframes to prevent users from accidentally permanently mangling their entry. I will implement a menu to restore a given deleted saveframe like we discussed.

@jonwedell
Copy link
Member

Duplicate of #53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants