Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files without categories read ok #100

Closed
locsmith opened this issue Jun 19, 2021 · 2 comments
Closed

Files without categories read ok #100

locsmith opened this issue Jun 19, 2021 · 2 comments

Comments

@locsmith
Copy link
Contributor

If i don't add a category in the API of a frame the API complains loudly, but importing a star file without categories in the Saveframe doesn't raise warnings. Is this correct?

@jonwedell
Copy link
Member

This is in accordance with the https://en.wikipedia.org/wiki/Robustness_principle.

Basically, a user of PyNMR-STAR may be reading files from a variety of sources, some of which have been generated by others, and may have issues. Unless the issue is so severe that it prevents coherent parsing entirely, the library attempts to accept what it is given when reading files.

On the other hand, if you are creating NMR-STAR files yourself, the library does its best to push you to generate correct files to the best of its ability.

@jonwedell
Copy link
Member

As with your other issue though, a more dedicated NEF-mode may enable me to silence some of these warnings where not appropriate. I'll definitely consider it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants