Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH_TYPE not set #18

Open
lhoekenga opened this issue Sep 1, 2011 · 0 comments
Open

AUTH_TYPE not set #18

lhoekenga opened this issue Sep 1, 2011 · 0 comments

Comments

@lhoekenga
Copy link

mod_auth_openid doesn't seem to be setting the AUTH_TYPE environment variable (which things like basic and digest do).

There is a check in mod_auth_openid.cpp that checks auth_type..

// if we're not enabled for this location/dir, decline doing anything
const char *current_auth = ap_auth_type(r);
if (!current_auth || strcasecmp(current_auth, "openid"))
return DECLINED;

but as far as I can tell... auth_type never gets set. I might be totally wrong, but I'd think you'd want to set auth_type to "openid", and change the test to something like...

if (!current_auth || ( strcasecmp(current_auth, "openid") != 0 ))
return DECLINED;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant