New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache-Control header not being sent with r->headers_out; works for r->err_headers_out #44

Open

shaunbrady opened this issue Feb 15, 2013 · 0 comments

shaunbrady commented Feb 15, 2013

https://github.com/bmuller/mod_auth_openid/blob/master/src/http_helpers.cpp#L85
I can confirm that switching the above line to:
apr_table_setn(r->err_headers_out, "Cache-Control", "no-cache");
sends the Cache-Control header to the user agent. Otherwise I have never observed it sent.

I might also suggest "no-cache, must-revalidate", as I have read that Firefox will sometimes ignore no-cache.
http://www-archive.mozilla.org/projects/netlib/http/http-caching-faq.html

SB

shaunbrady mentioned this issue

Changed Cache-Control header to be sent via err_headers_out #47

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment