-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generics in modules/import multiple layers #594
Comments
I would suggest to:
- raise issues for separate problems
- have cross references between issues ("is related to hash key numberX")
This way it becomes apparent, what might be better tackled in one big change/update.
Do not create a "all issues in one"-report as you then have to leave it open until all issues are ironed out.
That "all in one thing" is something Brucey could do in a Pull Request...
Creating a custom branch ("fix_generics") and in the Pull Request to the master/main branch an issue/discussion is automatically linked to it.
There you can maintain a list of issues (checkbox style) which your PR is planned to solve. With commits to that branch you then step by step fulfill the check list. People can peek already what each commit will change, can discuss issues they see in the current state (of the branch...).
Then when eg Brucey think he is done with it, people could review the PR, eg. cross-check the referenced issues (top post of the PR contains then eg some "closes hashkey numberx").
Afterwards Brucey could simply merge the PR and voila...properly worked on multiple issue resolves.
|
Ah, I see! Thanks for the input @GWRon 😊 |
The error message I get is the following:
Thanks. |
Any chance you could take a look at this any time soon @woollybah? I have modules that are using the generic types from BRL.Collections, and if I use said modules and try to use another generic type from BRL.Collections it doesn't work :( |
Unfortunately, I don't think generics in BlitzMax are in a usable state as of right now. |
Ah okey, I see - that's too bad. |
Seems something has gone even more wrong with this now, I have this type TDoubleMap which is a nested TTreeMap and the TDoubleMap module won't compile at all now which it used to do. Perhaps it's the updated MinGW that caused this?
Using latest of everything as far as I know. Thanks! |
It appears this last one happens when I create a TDoubleMap but does not use it, so it does not seem to be related to the nested modules issue. |
It seems that using generic types in a multiple "layer" of modules can cause compile errors.
test.mod/test1.mod/test1.bmx
test.mod/test2.mod/test2.bmx
test.bmx
Perhaps I should gather all the bugs related to generics in a single place for your convenience @woollybah?
Generics is such a useful & powerful feature and it works really well aside from a few bugs, so I'd be really really swell if you would take a look at it sometime in the near future! 😊
Thanks!
-- Thareh
Environment
bcc -v
: 0.133The text was updated successfully, but these errors were encountered: