-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R]: resolve best practice advice #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[R4R] Prepare for release v1.0.0-beta.0
unclezoro
changed the title
WIP: resolve best practice advice
[R4R]: resolve best practice advice
Aug 5, 2020
unclezoro
approved these changes
Aug 5, 2020
yutianwu
approved these changes
Aug 5, 2020
irrun
added a commit
to irrun/bsc
that referenced
this pull request
Apr 26, 2024
* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401) (cherry picked from commit fb435eb) * fix: bundlepool concurrent read and write and commit blob tx issue * feat: set MaxBundleAliveBlock as bundle's default ddl --------- Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: irrun <irunert@gmail.com>
redhdx
added a commit
to redhdx/bsc
that referenced
this pull request
May 30, 2024
* builder: implement BEP322 builder-api (bnb-chain#7) * feat: mev-builder * consesus: add a interface to set validator at runtime * core/txpool: add bundlepool to maintain bundle txs * core/type: define bundle * internal/ethapi: add sendBundle, bundlePrice, unregis * ethclient: add SendBundle * miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators * add README.builder.md --------- Co-authored-by: raina <irunert@gmail.com> * fix: index out of range (bnb-chain#10) * feat: call mev_params before send bid (bnb-chain#12) * fix: NPE and wrong profit (bnb-chain#13) * doc: update README.builder.md (bnb-chain#14) * fix: concurrent map write issue (bnb-chain#15) * fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17) * fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19) * feat: sendBundle return bundle hash (bnb-chain#20) * fix: some builder issues (bnb-chain#22) * fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401) (cherry picked from commit fb435eb) * fix: bundlepool concurrent read and write and commit blob tx issue * feat: set MaxBundleAliveBlock as bundle's default ddl --------- Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: irrun <irunert@gmail.com> * fix: typo in `BundlePool.AllBundles` (bnb-chain#24) * feat: add `reconnectLoop` for mev validators (bnb-chain#25) * feat: add `reconnectLoop` for mev validators * fix lint issue * fix review comments * fix review comments * feat: ethclient of bundle (bnb-chain#23) * fix: a nil pointer when query bundle price (bnb-chain#28) * feat: set unrevertible tx hashes when sendBid --------- Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com> Co-authored-by: raina <irunert@gmail.com> Co-authored-by: Roshan <luoshen1997@gmail.com> Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: zoro <296179868@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.