Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]add gas limit check in parlia implement #10

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Jun 17, 2020

Currently clique and parlia do not check the gas-limit and gas-used, it may cause security issue.
However, because of the system transactions, the gas-used of parlia implement may exceed the gas-limit, so we reserve about 100000 gas for system transactions. For now system transaction cost 22,748+ 1,516 + 24,439 = 48703 gas at most. resolve issue #9

@yutianwu yutianwu merged commit 9f1aaec into bnb-chain:develop Jun 18, 2020
unclezoro added a commit to unclezoro/bsc that referenced this pull request Nov 24, 2021
flywukong pushed a commit to flywukong/bsc that referenced this pull request Mar 11, 2022
realuncle pushed a commit to realuncle/bsc that referenced this pull request Mar 16, 2022
swlfigo added a commit to swlfigo/bsc-official that referenced this pull request Apr 27, 2023
* tx

* tx

* Simulator

* RLP

* RPC

* RPC

* RPC

* 新增Unknown Address To Swap事件

* SwapSig

* 抽取Pair等数据结构到公共文件&&新增Simulator Tx RPC&&监听Unknow Router 监控
irrun added a commit to irrun/bsc that referenced this pull request Apr 26, 2024
redhdx added a commit to redhdx/bsc that referenced this pull request May 30, 2024
* builder: implement BEP322 builder-api (bnb-chain#7)

* feat: mev-builder

* consesus: add a interface to set validator at runtime
* core/txpool: add bundlepool to maintain bundle txs
* core/type: define bundle
* internal/ethapi: add sendBundle, bundlePrice, unregis
* ethclient: add SendBundle
* miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators
* add README.builder.md
---------

Co-authored-by: raina <irunert@gmail.com>

* fix: index out of range (bnb-chain#10)

* feat: call mev_params before send bid (bnb-chain#12)

* fix: NPE and wrong profit (bnb-chain#13)

* doc: update README.builder.md (bnb-chain#14)

* fix: concurrent map write issue (bnb-chain#15)

* fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17)

* fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19)

* feat: sendBundle return bundle hash (bnb-chain#20)

* fix: some builder issues (bnb-chain#22)

* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>

* fix: typo in `BundlePool.AllBundles` (bnb-chain#24)

* feat: add `reconnectLoop` for mev validators (bnb-chain#25)

* feat: add `reconnectLoop` for mev validators

* fix lint issue

* fix review comments

* fix review comments

* feat: ethclient of bundle (bnb-chain#23)

* fix: a nil pointer when query bundle price (bnb-chain#28)

* feat: set unrevertible tx hashes when sendBid

---------

Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com>
Co-authored-by: raina <irunert@gmail.com>
Co-authored-by: Roshan <luoshen1997@gmail.com>
Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: zoro <296179868@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants