Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fast node to rewind after abnormal shutdown #2401

Merged

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Apr 17, 2024

Description

fix: allow fast node to rewind after abnormal shutdown

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 force-pushed the fix_fast_node_start_after_force_kill branch 2 times, most recently from ce310e9 to 1ad737a Compare April 18, 2024 02:06
@buddh0 buddh0 force-pushed the fix_fast_node_start_after_force_kill branch from 1ad737a to fcae02a Compare April 18, 2024 02:07
@buddh0 buddh0 marked this pull request as ready for review April 18, 2024 02:08
@buddh0 buddh0 requested a review from zzzckck as a code owner April 18, 2024 02:08
@zzzckck zzzckck merged commit fb435eb into bnb-chain:develop Apr 18, 2024
7 checks passed
Pythonberg1997 pushed a commit to bnb-chain/bsc-builder that referenced this pull request Apr 23, 2024
Pythonberg1997 added a commit to bnb-chain/bsc-builder that referenced this pull request Apr 25, 2024
* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>
@buddh0 buddh0 deleted the fix_fast_node_start_after_force_kill branch May 7, 2024 11:04
redhdx added a commit to redhdx/bsc that referenced this pull request May 30, 2024
* builder: implement BEP322 builder-api (bnb-chain#7)

* feat: mev-builder

* consesus: add a interface to set validator at runtime
* core/txpool: add bundlepool to maintain bundle txs
* core/type: define bundle
* internal/ethapi: add sendBundle, bundlePrice, unregis
* ethclient: add SendBundle
* miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators
* add README.builder.md
---------

Co-authored-by: raina <irunert@gmail.com>

* fix: index out of range (bnb-chain#10)

* feat: call mev_params before send bid (bnb-chain#12)

* fix: NPE and wrong profit (bnb-chain#13)

* doc: update README.builder.md (bnb-chain#14)

* fix: concurrent map write issue (bnb-chain#15)

* fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17)

* fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19)

* feat: sendBundle return bundle hash (bnb-chain#20)

* fix: some builder issues (bnb-chain#22)

* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>

* fix: typo in `BundlePool.AllBundles` (bnb-chain#24)

* feat: add `reconnectLoop` for mev validators (bnb-chain#25)

* feat: add `reconnectLoop` for mev validators

* fix lint issue

* fix review comments

* fix review comments

* feat: ethclient of bundle (bnb-chain#23)

* fix: a nil pointer when query bundle price (bnb-chain#28)

* feat: set unrevertible tx hashes when sendBid

---------

Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com>
Co-authored-by: raina <irunert@gmail.com>
Co-authored-by: Roshan <luoshen1997@gmail.com>
Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: zoro <296179868@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants