Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hyper-zigorat theme #136

Merged
merged 3 commits into from
Dec 11, 2016
Merged

added hyper-zigorat theme #136

merged 3 commits into from
Dec 11, 2016

Conversation

dotamir
Copy link
Contributor

@dotamir dotamir commented Nov 13, 2016

Checklist for submitting an awesome plugin, theme, or resource:

  • The title for my package or theme uses its npm title (hyper-plugin-example)
  • The link for my package or theme uses the npmjs.com link (https://www.npmjs.com/package/hyper-plugin-example)
  • There is a visual representation of what my plugin or theme does in the repo. (Plugin: screenshot or gif || Theme: screenshot of the theme applied to Hyper)
  • Put your awesome item at the BOTTOM of the correct (plugin, theme, or resource) list.
  • VERY IMPORTANT: I've written a short (one sentence) description for my package or theme as the description of the awesome plugin, theme, or resource in the README.md file I'm submitting in the PR.

@matheuss
Copy link
Collaborator

@dotamir would you mind adding a screenshot of the theme to its README.md? 😅

@dotamir
Copy link
Contributor Author

dotamir commented Nov 16, 2016

Oh sorry 😄
now added screenshot to README.md .

@bnb
Copy link
Owner

bnb commented Nov 27, 2016

@dotamir Looks like the screenshot's broken 😟 If you could fix it, I'd be happy to fix the README.md and merge this!

@dotamir
Copy link
Contributor Author

dotamir commented Dec 3, 2016

@bnb I checked this problem, It's Ok.

@iamstarkov
Copy link
Collaborator

I checked this problem, It's Ok.

@dotamir, what do you mean?

@iamstarkov
Copy link
Collaborator

@dotamir seems like screenshot isnt fixed
screen shot 2016-12-10 at 2 57 06 am

@iamstarkov
Copy link
Collaborator

image pointed to Screenshot.png

@iamstarkov
Copy link
Collaborator

oh, i see

@iamstarkov
Copy link
Collaborator

there are two options, why this is happening:

  1. you added a screenshot, but didnt publish new version
  2. npm rendering is broken somehow, if its the case, then just replicate how other themes includes images, likey hyperterm-ayu https://raw.githubusercontent.com/licatajustin/hyperterm-ayu/master/README.md

@iamstarkov
Copy link
Collaborator

and can you rename a project to hyper-zigorat?

Copy link
Collaborator

@iamstarkov iamstarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot needs to be fixed + renaming

@dotamir dotamir changed the title added hyperterm-zigorat theme added hyper-zigorat theme Dec 10, 2016
@dotamir
Copy link
Contributor Author

dotamir commented Dec 10, 2016

@iamstarkov @bnb sorry for problems :)
renamed to 'hyper-zigorat' and screenshot fixed. everything it's ok.

@iamstarkov
Copy link
Collaborator

your changes are now fine

@iamstarkov
Copy link
Collaborator

but master branch has been updated several time now, can you rebase your branch on latest master?

@iamstarkov iamstarkov merged commit 88c7247 into bnb:master Dec 11, 2016
@darahak darahak mentioned this pull request Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants