Skip to content

Commit

Permalink
Merge pull request #272 from bndr/bye_travis
Browse files Browse the repository at this point in the history
Drop Travis as our CI provider

Since travis changed its pricing policy it has become more limited in
what we can accomplish with it. It now uses a limited credit model for
open source projects which besides being cumbersome puts the project in
a precarious position where we may be unable to run tests if we dont
have any credits left.

For this reason we will be moving to github actions since they seem to
be the best alternative at the moment

I also dropped flake8 from our tox tests in favor of reviewdog
Review dog is an incredible project that makes linting and formatting
review a breeze by commenting inline what is wrong in a pull request.
This makes the review process easier for the maintainer and also
provides a clearer feedback to the contributor

This new test workflow utilizes a few interesting projects to make this action
easier to maintain such as the coveralls github action
and the tox-gh-actions project
  • Loading branch information
alan-barzilay committed Sep 4, 2021
2 parents c8ab8cb + bc8121e commit 9a2ae29
Show file tree
Hide file tree
Showing 6 changed files with 81 additions and 42 deletions.
1 change: 0 additions & 1 deletion .coveralls.yml

This file was deleted.

20 changes: 20 additions & 0 deletions .github/workflows/flake8.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: flake8

on: pull_request

jobs:
flake8-lint:
runs-on: ubuntu-latest
name: Lint
steps:
- name: Check out source repository
uses: actions/checkout@v2
- name: Set up Python environment
uses: actions/setup-python@v2
with:
python-version: "3.9"
- name: flake8 Lint
uses: reviewdog/action-flake8@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-review
50 changes: 50 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Tests and Codecov
on: pull_request
jobs:
run_tests:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, pypy-3.7]

steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install tox tox-gh-actions
- name: Test with tox
run: tox

coverage_report:
needs: run_tests
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install coverage docopt yarg requests
- name: Calculate coverage
run: coverage run --source=pipreqs -m unittest discover

- name: Create XML report
run: coverage xml

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
with:
files: coverage.xml
fail_ci_if_error: true
30 changes: 0 additions & 30 deletions .travis.yml

This file was deleted.

5 changes: 2 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@
:target: https://pypi.python.org/pypi/pipreqs


.. image:: https://img.shields.io/coveralls/bndr/pipreqs.svg
:target: https://coveralls.io/r/bndr/pipreqs

.. image:: https://codecov.io/gh/bndr/pipreqs/branch/master/graph/badge.svg?token=0rfPfUZEAX
:target: https://codecov.io/gh/bndr/pipreqs

.. image:: https://img.shields.io/pypi/l/pipreqs.svg
:target: https://pypi.python.org/pypi/pipreqs
Expand Down
17 changes: 9 additions & 8 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
[tox]
envlist = py36, py37, py38, py39, pypy3, flake8

[gh-actions]
python =
3.6: py36
3.7: py37
3.8: py38
3.9: py39
pypy-3.7: pypy3

[testenv]
setenv =
PYTHONPATH = {toxinidir}:{toxinidir}/pipreqs
commands = python setup.py test
deps =
-r{toxinidir}/requirements.txt

[testenv:flake8]
basepython = python3.9
commands = flake8 pipreqs
deps =
-r{toxinidir}/requirements.txt
flake8
-r{toxinidir}/requirements.txt

0 comments on commit 9a2ae29

Please sign in to comment.