Drop Travis as our CI provider #272
Conversation
|
just a disclaimer that this is a work in progress, testing this CI is complicated because there is no way (afaik) of testing it locally. I'm currently working on de-duplicating checks and investigating why some tests are being cancelled |
alan-barzilay
force-pushed
the
bye_travis
branch
3 times, most recently
from
661816b
to
e9e2f91
Compare
Since travis changed its pricing policy it has become more limited in what we can accomplish with it. It now uses a limited credit model for open source projects which besides being cumbersome puts the project in a precarious position where we may be unable to run tests if we dont have anymore credits. For this reason we will be moving to github actions since they seem to be the best alternative at the moment
alan-barzilay
force-pushed
the
bye_travis
branch
6 times, most recently
from
4a1cd9f
to
3189fc4
Compare
Codecov Report
@@ Coverage Diff @@
## next #272 +/- ##
=======================================
Coverage ? 87.50%
=======================================
Files ? 2
Lines ? 256
Branches ? 0
=======================================
Hits ? 224
Misses ? 32
Partials ? 0 Continue to review full report at Codecov.
|
|
ok, so I cant find a way to keep using coveralls which sucks because we loose our coverage history. Uploading to coveralls without using the github action is really buggy, however the github action only supports reports in lcov format which i couldn't manage to create. See coverallsapp/github-action#30 After 3 hours trying I gave up and tried codecov which just worked in 5 minutes. So unless someone finds a way to keep using coveralls, we will be using codecov from now on |
alan-barzilay
force-pushed
the
bye_travis
branch
3 times, most recently
from
3958998
to
9a12295
Compare
Review dog is an incredible project that makes linting and formatting review a breeze by commenting inline what is wrong in a pull request. This makes the review process easier for the maintainer and also provides a clearer feedback to the contributor
alan-barzilay
force-pushed
the
bye_travis
branch
from
9a12295
to
2b59751
Compare
|
I tested this new CI with a dummy PR and everything seems to be working as expected! #273 |
|
also, our tests do not respect flake8, changing CI made this evident. I will be opening an issue about this |
alan-barzilay
force-pushed
the
bye_travis
branch
from
2b59751
to
b9865dd
Compare
This commit essentially adds back tests to our CI pipeline. They were previously dropped due to Travis pricing policy change. This workflow utilizes a few interesting projects to make this action easier to maintain such as the codecov github action and the tox-gh-actions project (https://github.com/ymyzk/tox-gh-actions) This commit uses codecov instead of coveralls because using coveralls directly inside GH-actions is buggy and the official coveralls action only supports lcov reports which we can't seem to be able to generate at the moment. For more information see the pull request that introduced this commit
alan-barzilay
force-pushed
the
bye_travis
branch
from
b9865dd
to
bc8121e
Compare
Since travis changed its pricing policy it has become more limited in
what we can accomplish with it. It now uses a limited credit model for
open source projects which besides being cumbersome puts the project in
a precarious position where we may be unable to run tests if we dont
have any credits left.
For this reason we will be moving to github actions since they seem to
be the best alternative at the moment
I also dropped flake8 from our tox tests in favor of reviewdog
Review dog is an incredible project that makes linting and formatting
review a breeze by commenting inline what is wrong in a pull request.
This makes the review process easier for the maintainer and also
provides a clearer feedback to the contributor
This new test workflow utilizes a few interesting projects to make this action
easier to maintain such as the coveralls github action
and the tox-gh-actions project
This PR, as mentioned in #252, is necessary to get back our CI pipeline and to confidently make a new pipreqs release